On 09/02/2014 04:24 AM, Peter Maydell wrote: > Convert the udp char backend to the new style QAPI framework. > > Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> > --- > qemu-char.c | 69 > +++++++++++++++++++++++++++++++++++++++++++++++-------------- > 1 file changed, 54 insertions(+), 15 deletions(-) >
> +
> + if (host == NULL || strlen(host) == 0) {
> + host = "localhost";
> + }
> + if (port == NULL || strlen(port) == 0) {
> + error_setg(errp, "chardev: udp: remote port not specified");
In the common case of these strings being non-empty, you end up having
to hunt for the end of the string only to then throw that information
away. Rather than 'strlen(foo) == 0)', it's slightly faster to check
'*foo' for being a non-NUL byte.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
