On 04.09.14 13:13, Aravinda Prasad wrote: > Extend rtas-blob to accommodate error log. Error log > structure is saved in rtas space upon a machine check > exception. > > Signed-off-by: Aravinda Prasad <aravi...@linux.vnet.ibm.com> > --- > hw/ppc/spapr.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c > index 4b20e36..4a7c0ae 100644 > --- a/hw/ppc/spapr.c > +++ b/hw/ppc/spapr.c > @@ -1409,6 +1409,10 @@ static void ppc_spapr_init(MachineState *machine) > > filename = qemu_find_file(QEMU_FILE_TYPE_BIOS, "spapr-rtas.bin"); > spapr->rtas_size = get_image_size(filename); > + > + /* Resize blob to accommodate error log at a page aligned address */ > + spapr->rtas_size = TARGET_PAGE_ALIGN(spapr->rtas_size) + > TARGET_PAGE_SIZE;
I think it's clearer if you do #define RTAS_ERROR_LOG_SIZE 4096 and add this to the aligned size instead. Alex