Re: [Qemu-devel] [PATCH] Added Cortex_a8_v3 version, and added a shift instruction for NEON.

[Richard Henderson]

On 02/18/2010 03:56 PM, George Karavaev wrote:
> +                            tmp64 = tcg_temp_new_i64();
> +                            tcg_gen_movi_i64(tmp64, 0);
> +                            tcg_gen_not_i64(tmp64, tmp64);

movi -1?

> +                            gen_helper_neon_shl_u64(tmp64, tmp64, cpu_V1);
> +                            tcg_gen_and_i64(cpu_V0, cpu_V0, tmp64); /*
> XXX */

Why the XXX?

> +                            tcg_gen_not_i64(tmp64, tmp64);
> +                            tcg_gen_and_i64(cpu_V1, cpu_V1, tmp64);

tcg_gen_andc_i64.


r~