Lluís Vilanova writes: > Adds QAPI/QMP commands to control tracing events, and reimplements some of the > related HMP commands on top.
Ping. Thanks, Lluis > NOTE: The "trace-event-set-state" command uses a bool 'enable' argument > instead > of an enum 'state'. I'm still not sure if an enum is better than the two > separate booleans. > Signed-off-by: Lluís Vilanova <vilan...@ac.upc.edu> > --- > Changes in v4: > * Split QAPI/QMP and HMP changes into separate patches. > * Add copyright information in QAPI file (Eric Blake). > * Replace event state booleans with an enum (Eric Blake). > * Document pattern type for argument "name" (Eric Blake). > * Other documentation improvements (Markus Armbruster). > * Change "keepgoing" to "ignore-unavailable" (Markus Armbruster). > * Add examples in QMP command definition file (Eric Blake). > * Propagate QMP errors to HMP (Markus Armbruster, Stefan Hajnoczi). > * Remove trailing newlines when using error_setg (Stefan Hajnoczi). > * Avoid multiple invocations of error_setg (Stefan Hajnoczi). > * Various cosmetic changes (Markus Armbruster). > Lluís Vilanova (2): > trace: [qmp] Add commands to query and control event tracing state > trace: [hmp] Reimplement "trace-event" and "info trace-events" using QMP > monitor.c | 27 ++++++++++-------- > qapi-schema.json | 3 ++ > qapi/trace.json | 65 ++++++++++++++++++++++++++++++++++++++++++++ > qmp-commands.hx | 35 ++++++++++++++++++++++++ > trace/Makefile.objs | 1 + > trace/control.c | 13 --------- > trace/control.h | 7 ----- > trace/qmp.c | 75 > +++++++++++++++++++++++++++++++++++++++++++++++++++ > 8 files changed, 193 insertions(+), 33 deletions(-) > create mode 100644 qapi/trace.json > create mode 100644 trace/qmp.c > To: qemu-devel@nongnu.org > Cc: Michael Roth <mdr...@linux.vnet.ibm.com> > Cc: Markus Armbruster <arm...@redhat.com> > Cc: Stefan Hajnoczi <stefa...@redhat.com> > Cc: Luiz Capitulino <lcapitul...@redhat.com> -- "And it's much the same thing with knowledge, for whenever you learn something new, the whole world becomes that much richer." -- The Princess of Pure Reason, as told by Norton Juster in The Phantom Tollbooth
