On 09/11/2014 06:49 AM, Stefan Hajnoczi wrote:
> Commit 3718d8ab65f68de2acccbe6a315907805f54e3cc ("block: Replace in_use
> with operation blocker") broke the error path because it consumed
> local_err instead of propagating it.
> 
> The caller has no way to know that the function failed.  This caused
> virtio-blk to start "successfully" even though there was a fatal
> dataplane error.
> 

> ---
>  hw/block/dataplane/virtio-blk.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Eric Blake <ebl...@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to