Il 12/09/2014 09:30, arei.gong...@huawei.com ha scritto: > From: Gonglei <arei.gong...@huawei.com> > > qerror_report() is a transitional interface to help with converting > existing HMP commands to QMP. It should not be used elsewhere. > > v2 -> v1: > - update including head files, remove qerror.h and monitor.h, > add error-report.h (Markus) > - add 'Reviewed-by' tag. > > Gonglei (2): > redirect.c: Don't use qerror_report() > dev-network: Don't use qerror_report_err() > > hw/usb/dev-network.c | 4 ++-- > hw/usb/redirect.c | 8 ++++---- > 2 files changed, 6 insertions(+), 6 deletions(-) >
This is not an improvement I think; patch 1 especially for patch 2 where you are discarding the Error *. Any chance you could convert USB from init to realize, instead? Then you can remove the error printing altogether, and just the obsolete functions. Paolo