Il 18/09/2014 11:32, arei.gong...@huawei.com ha scritto:
> @@ -460,7 +460,7 @@ static void usb_serial_event(void *opaque, int event)
> break;
> case CHR_EVENT_OPENED:
> if (!s->dev.attached) {
> - usb_device_attach(&s->dev);
> + usb_device_attach(&s->dev, NULL);
After this patch, this stops printing the error if the attach fails.
Please add qerror_report_err.
> }
> break;
> case CHR_EVENT_CLOSED:
> @@ -489,7 +489,7 @@ static int usb_serial_initfn(USBDevice *dev)
> usb_serial_handle_reset(dev);
>
> if (s->cs->be_open && !dev->attached) {
> - usb_device_attach(dev);
> + usb_device_attach(dev, NULL);
This too. Please add qerror_report_err here too and, in this case,
please make patch 12 pass the errp instead of using qerror_report_err.
Paolo
> }
> return 0;
