> From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: Friday, September 19, 2014 2:06 PM > To: Gonglei (Arei) > Subject: Re: [PATCH v2 00/19] usb: convert device init to realize > > On Do, 2014-09-18 at 20:47 +0800, arei.gong...@huawei.com wrote: > > From: Gonglei <arei.gong...@huawei.com> > > > > DeviceClass->init is the old interface, let's convert usb > > devices to the new realize API. In this way, all the > > implementations now use error_setg instead of > > qerror_report/error_report for reporting error. > > Looks good overall. One minor style nit, and there is the usb-serial > issue pointed out by paolo, I'd like to see them handled. I don't care > much whenever you do than with a v3 or 2-3 incremental patches to this > one. > Got it. Thanks. :)
Best regards, -Gonglei
