On Mon, 09/22 10:09, Paolo Bonzini wrote: > Il 22/09/2014 07:56, Fam Zheng ha scritto: > >> > > >> > Please add these to VirtIOSCSI rather than VirtIOSCSICommon. Same for > >> > the new functions you declare below. > > What's the rationale, please? Asking because especially the VirtIOSCSIVring > > fields are the dataplane counterparts of VirtQueue fields, so putting in > > VirtIOSCSI seems unnatural for me. > > Because everything you put in VirtIOSCSICommon will be shared between > virtio-scsi and vhost-scsi, and vhost-scsi need not use neither vring > nor dataplane. >
I see, I'll move it into VirtIOSCSI then! Fam
