On 09/22/2014 08:25 AM, Paolo Bonzini wrote: > Il 22/09/2014 15:15, Corey Minyard ha scritto: >>>> Why move this from qemu_chr_finish_socket_connection to tcp_chr_connect? >>>> Perhaps move this part of the patch earlier, either just before or just >>>> after patch 2? >> I had to make this change, otherwise a server socket would never show >> that it reconnected. I originally hadn't moved it. > Reconnected or connected? How does reconnection work with server > sockets? I guess you can then move it to patch 2.
When a server socket disconnects, it runs through the disconnect code so it shows "disconnected". It does not call qemu_chr_finish_socket_connection when it reconnects, though, so it would never show the new connection. I can move it to patch 2, but it seems more logical to me here, since it doesn't really matter until this patch. Thanks, -corey
