On Mon, 09/22 14:32, Max Reitz wrote: > On 22.09.2014 09:15, Fam Zheng wrote: > >This fixes the bug introduced by commit c6ac36e (vmdk: Optimize cluster > >allocation). > > > >$ ~/build/master/qemu-io /stor/vm/arch.vmdk -c 'write 2G 1k' > >write failed: Invalid argument > > > >Reported-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> > >Signed-off-by: Fam Zheng <f...@redhat.com> > > > >--- > >v4: Fix typo in file header: 1014 -> 2014. > >v3: A new case 105 instead of embedding in 005. (Max) > >--- > > block/vmdk.c | 2 +- > > tests/qemu-iotests/105 | 70 > > ++++++++++++++++++++++++++++++++++++++++++++++ > > tests/qemu-iotests/105.out | 21 ++++++++++++++ > > 3 files changed, 92 insertions(+), 1 deletion(-) > > create mode 100755 tests/qemu-iotests/105 > > create mode 100644 tests/qemu-iotests/105.out > > I'm sorry, but you didn't add the respective line to the group file. Also, > the reference output is wrong; for the latter two accesses, it should be "at > offset 15393162788864" (14T) instead of "at offset 4398046511104" (4T).
Oops I saw a no-op when running check, but thought it passed! > > Those changes are trivial, though, so with an appropriate line in > tests/qemu-iotests/group and %s/4398046511104/15393162788864/ in > tests/qemu-iotests/105.out: Thanks so much for your careful reviewing! I am fixing this and picking up your rev-by line in v5. Fam > > Reviewed-by: Max Reitz <mre...@redhat.com>
