On 22 September 2014 23:19, Paolo Bonzini <pbonz...@redhat.com> wrote: > Il 22/09/2014 22:57, Richard Henderson ha scritto: >> +QEMU_BUILD_BUG_ON(TCG_TARGET_NB_REGS > 32); >> +QEMU_BUILD_BUG_ON(NB_MMU_MODES > 8); >> + >> typedef struct TCGLabelQemuLdst { >> - bool is_ld:1; /* qemu_ld: true, qemu_st: false */ >> - TCGMemOp opc:4; >> - TCGReg addrlo_reg; /* reg index for low word of guest virtual addr >> */ >> - TCGReg addrhi_reg; /* reg index for high word of guest virtual >> addr */ >> - TCGReg datalo_reg; /* reg index for low word to be loaded or >> stored */ >> - TCGReg datahi_reg; /* reg index for high word to be loaded or >> stored */ >> - int mem_index; /* soft MMU memory index */ >> + TCGMemOp opc : 4; >> + bool is_ld : 1; /* qemu_ld: true, qemu_st: false */ >> + TCGReg addrlo_reg : 5; /* reg index for low word of guest virtual addr >> */ >> + TCGReg addrhi_reg : 5; /* reg index for high word of guest virtual >> addr */ >> + TCGReg datalo_reg : 5; /* reg index for low word to be loaded or >> stored */ >> + TCGReg datahi_reg : 5; /* reg index for high word to be loaded or >> stored */ >> + unsigned mem_index : 3; /* soft MMU memory index */ >> + /* 4 bits unused in 32-bit word */ > > Why? Are there more than 10 or so loads in the typical tb?
For clarity, does this comment amount to a request for me not to apply this pullreq? thanks -- PMM