Il 25/09/2014 04:01, Fam Zheng ha scritto: >>> > > -static void virtio_scsi_do_tmf(VirtIOSCSI *s, VirtIOSCSIReq *req) >>> > > +typedef struct { >>> > > + VirtIOSCSIReq *tmf_req; >>> > > + int remaining; >>> > > +} VirtIOSCSICancelTracker; >> > >> > What about putting "remaining" directly in VirtIOSCSIReq? > It's rarely used, so I preferred managing it here. >
It complicates the code though. If you really feel like economizing space, put it in a union with "QTAILQ_ENTRY(VirtIOSCSIReq) next;". Paolo