On 2014/9/29 15:48, Markus Armbruster wrote:
zhanghailiang <zhang.zhanghaili...@huawei.com> writes:
The second parameter of dump_error is unused, but one purpose of
using this function is to report the error info.
Use error_set to return the error info to the caller.
Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com>
The commit message doesn't explain this patch's benefit clearly.
Suggest:
dump: Propagate errors into qmp_dump_guest_memory()
The code calls dump_error() on error, and even passes it a suitable
message. However, the message is thrown away, and its callers pass
up only success/failure. All qmp_dump_guest_memory() can do is set
a generic error.
Propagate the errors properly, so qmp_dump_guest_memory() can return
a more useful error.
With a commit message like that:
Reviewed-by: Markus Armbruster <arm...@redhat.com>
OK, Will fix like that, and submit V7, thanks very much;)
