On Tue, Sep 30, 2014 at 09:59:30AM +0200, Gerd Hoffmann wrote: > Hi, > > > > case 15: > > > - v = VGA_DRAW_LINE15; > > > + v = big_endian_fb ? VGA_DRAW_LINE15_BE : VGA_DRAW_LINE15_LE; > > > bits = 16; > > > break; > > > case 16: > > > - v = VGA_DRAW_LINE16; > > > + v = big_endian_fb ? VGA_DRAW_LINE16_BE : VGA_DRAW_LINE16_LE; > > > bits = 16; > > > break; > > > > So, v1 changed both of these cases to bits = 15, which looked wrong > > for case 16. v2 changes neither, which looks wrong for case 15. Or > > is there a reason it should be 16 for case 15? > > It is correct. The '15' is the color depth, and 'bits' is the number of > bits per pixel, which is 16 because the color format uses two bytes per > pixel and one of the bits is unused.
Ok, then:
Reviewed-by: David Gibson <da...@gibson.dropbear.id.au>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
pgp7rcdsHNnT6.pgp
Description: PGP signature
