Il 30/09/2014 11:04, Cornelia Huck ha scritto: > On Tue, 30 Sep 2014 14:10:38 +0800 > <arei.gong...@huawei.com> wrote: > >> From: Gonglei <arei.gong...@huawei.com> >> >> For better code sharing, add a wrapper help funciton > > typo: s/funciton/function/ > >> for various virtio devices. > > s/for various virtio devices/that handles referencing the virtio > backend for virtio proxy devices/ ? > >> >> Cc: Cornelia Huck <cornelia.h...@de.ibm.com> >> Cc: Michael S. Tsirkin <m...@redhat.com> >> Signed-off-by: Gonglei <arei.gong...@huawei.com> >> --- >> hw/s390x/s390-virtio-bus.c | 42 +++++++++++++++++---------------------- >> hw/s390x/virtio-ccw.c | 42 +++++++++++++++++---------------------- >> hw/virtio/virtio-pci.c | 49 >> ++++++++++++++++++++-------------------------- >> hw/virtio/virtio.c | 11 +++++++++++ >> include/hw/virtio/virtio.h | 3 +++ >> 5 files changed, 71 insertions(+), 76 deletions(-) > > I'm wondering whether we should call the wrapper for virtio-balloon as > well. Even if it does not have any properties to alias, calling > qdev_alias_all_properties() probably doesn't hurt, does it?
Actually it has properties to alias: guest-stats and guest-stats-polling-interval are effectively aliases, so we could remove 30-odd lines of code from virtio-pci and virtio-ccw. It's okay IMO to put it in a separate patch, since it is a bit different from the trivial replacement done here. Paolo
