Unfortunately, the arm_is_secure*() functions cannot be moved either as they are used within cpu.h.
Greg On 6 October 2014 16:07, Peter Maydell <peter.mayd...@linaro.org> wrote: > On 6 October 2014 21:47, Greg Bellows <greg.bell...@linaro.org> wrote: > > > > > > On 6 October 2014 15:07, Peter Maydell <peter.mayd...@linaro.org> wrote: > >> You should use is_a64() rather than directly looking at > >> env->aarch64, incidentally. > > > > > > Since I am touching arm_current_el(), should I go ahead and fix it to use > > is_a64() as well? > > Optional. > > > I'll move in v6. Should I also go ahead and move arm_current_el() to > > internals.h as well since I am touching it? > > No. Let's try to keep the scope of this patchset under control. > > -- PMM >
