On 10 October 2014 02:54, Chen Gang <gang.chen.5...@gmail.com> wrote: > I use the latest upstream gcc (which pulled from master in 2014-10-0?). > In my memory (not quite sure), the older version gcc may not notice > about this warning.
Hmm. I'll see if I can test with that gcc. > But for me, the warning (compiler worries about) sounds reasonable, and > it's harmless to be fixed (after have a look, for me, they are declared, > but never be used). It's a library. Other users of this code upstream will use these constants; it's just that we don't happen to. >> The reason I'm reluctant to make changes to these files is >> that they're pulled in from a different upstream project >> (libvixl) so we should only fix critical problems in them, >> or it makes new versions harder to update to. >> > > Originally, I first try the Xilinx branch (Xilinx-master from Xilinx > github), yesterday, and found this issue, then I try upstream main > branch, found the same issue. > > For me, when add the related patch (which will use these variables in > 'libvixl'), then declare and set them in the related headers, again. > That will let other reviewers and readers easier understanding. > > - removing them at present, is easy understanding. > > - add them again when really need them, is also easy understanding. But it's all changes which we would have to carry locally and then re-make every time we updated to a new libvixl. I definitely don't want to do that unless it's absolutely required. thanks -- PMM
