Hi Peter, On 2014/10/14 12:54, Peter Maydell wrote:
> On 14 October 2014 04:36, zhuyijun <zhuyi...@huawei.com> wrote: >> From: Zhu Yijun <zhuyi...@huawei.com> >> >> Commit 0b183fc871:"memory: move mem_path handling to >> memory_region_allocate_system_memory" split memory_region_init_ram and >> memory_region_init_ram_from_file. Also it moved mem-path handling a step >> up from memory_region_init_ram to memory_region_allocate_system_memory. >> >> Therefore for any board that uses memory_region_init_ram directly, >> -mem-path is not supported. >> >> Commit e938ba0c35:"ppc: memory: Replace memory_region_init_ram with >> memory_region_allocate_system_memory" have already fixed this on ppc. >> >> arm/arm64 board also occurs, this patch is only for arm64 board(virt). > > Why is this patch only changing this board? What's special > about virt that means we don't want to also make this > change for the other ARM boards? What about all the other > boards for the other architectures? > I think all of the other ARM boards should be changed. If changes in virt is ok, I will make the patch again including the modification of other ARM boards. Best regards, Yijun > The commit message for 0b183fc871 suggests we decided to > just break -mem-path for all those boards, which seems an > odd thing to do... Paolo? > > Incidentally I can't see anything that guards against > calling memory_region_allocate_system_memory() twice, > so I think you would end up with two blocks of RAM > both backed by the same file then. Or have I misread > the code? > > -- PMM > >
