On Mon, Oct 20, 2014 at 03:08:35PM +0100, Peter Maydell wrote: > On 20 October 2014 11:25, Stefan Hajnoczi <stefa...@redhat.com> wrote: > > Hi, > > At KVM Forum 2014 we discussed a patch checking bot that automates patch > > format checking and smoke testing: > > > > 1. Did the patch submitter include Signed-off-by? > > 2. Does checkpatch.pl pass? > > 3. Does the patch apply to qemu.git/master? > > 4. Does each patch compile? > > 5. Does the series pass make check and qemu-iotests? > > > > Here are some thoughts on the patch checker: > > > > If a patch series passes successfully, no email is sent. If a patch > > series fails, an email with the errors is sent as a reply to the patch > > series email thread. The patch submitter can then respond in case there > > are false positive (e.g. from checkpatch.pl) - the bot doesn't care > > about replies but it tells the human reviewers and maintainers what the > > patch submitter intends to do. > > Probably also worth having a feature where the cover > letter or patch can have a "patchchecker: no" line in > it to tell the bot to ignore something, so people can > avoid it sending lots of mail for patch series they > know don't apply to mainline (eg ones which depend on > a previous series).
The bot would send 1 email reply with a report of all errors. That doesn't seem too noisy. That said, a header line to ignore the series is easy to implement so we might as well. Stefan
pgpzWAzZ85z41.pgp
Description: PGP signature
