On Fri, Oct 03, 2014 at 06:47:08PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" <dgilb...@redhat.com> > > * Please comment on separate thread for this QEMUSziedBuffer patch * > > Modify some of tests/test-vmstate.c to use the in memory file based > on QEMUSizedBuffer to provide basic testing of QEMUSizedBuffer and > the associated memory backed QEMUFile type. > > Only some of the tests are changed so that the fd backed QEMUFile is > still tested. > > Signed-off-by: Dr. David Alan Gilbert <dgilb...@redhat.com> > Reviewed-by: Eric Blake <ebl...@redhat.com>
Reviewed-by: David Gibson <da...@gibson.dropbear.id.au>
Looks ok, although I do wonder if the removal of some of the test
paths for regular files is a concern.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
pgpsJLiWF7Mbn.pgp
Description: PGP signature
