Blue Swirl schrieb: > Thanks, applied. > > > On Wed, Jan 6, 2010 at 7:24 PM, Andreas Färber > <andreas.faer...@web.de> wrote: >> From: Andreas Färber <afaer...@opensolaris.org> >> >> Juan has contributed a cool Makefile infrastructure that enables us >> to drop >> static libraries completely: >> >> Move shared obj-y definitions to Makefile.objs, prefixed >> {common-,hw-,user-}, >> and link those object files directly into the executables. >> >> Replace HWLIB by HWDIR, specifying only the directory. >> >> Drop --whole-archive and ARLIBS in Makefiles and configure. >> >> Drop GENERATED_HEADERS dependency in rules.mak, since this rebuilds all >> common objects after generating a target-specific header; add dependency >> rules to Makefile and Makefile.target instead. >> >> v2: >> - Don't try to include /config.mak for user emulators >> - Changes to user object paths ("Quickfix for libuser.a drop") were >> obsoleted >> by "user_only: compile everything with -fpie" (Kirill A. Shutemov) >> >> v3: >> - Fix dependency modelling for tools >> - Remove comment on GENERATED_HEADERS obsoleted by this patch >> >> Signed-off-by: Andreas Färber <afaer...@opensolaris.org> >> Cc: Blue Swirl <blauwir...@gmail.com> >> Cc: Palle Lyckegaard <pa...@lyckegaard.dk> >> Cc: Ben Taylor <bentaylor.sol...@gmail.com> >> Cc: Juan Quintela <quint...@trasno.org> >> Cc: Kirill A. Shutemov <kir...@shutemov.name> >> Cc: Paolo Bonzini <pbonz...@redhat.com> >> --- >> Makefile | 138 +++++------------------------------------------- >> Makefile.hw | 33 +----------- >> Makefile.objs | 155 >> +++++++++++++++++++++++++++++++++++++++++++++++++++++++ >> Makefile.target | 33 +++++++++--- >> Makefile.user | 9 +--- >> configure | 34 +------------ >> rules.mak | 4 +- >> 7 files changed, 202 insertions(+), 204 deletions(-) >> create mode 100644 Makefile.objs >>
Removing libqemu.a was technically ok, but throws a license problem: "In particular, the QEMU virtual CPU core library (libqemu.a) is released under the GNU Lesser General Public License." Without libqemu.a, this part of QEMU's license no longer works. I think the best solution would be to add a rule for libqemu.a which allows users to build this static library (make libqemu.a). libqemu.a is also still needed for tests/qruncom. Regards, Stefan Weil