On 11/07/2014 12:39 PM, Kevin Wolf wrote: > This is forbidden if the raw driver was probed. > > Signed-off-by: Kevin Wolf <kw...@redhat.com> > --- > tests/qemu-iotests/109 | 100 ++++++++++++++++++++++++++++++ > tests/qemu-iotests/109.out | 149 > +++++++++++++++++++++++++++++++++++++++++++++ > tests/qemu-iotests/group | 1 + > 3 files changed, 250 insertions(+) > create mode 100755 tests/qemu-iotests/109 > create mode 100644 tests/qemu-iotests/109.out
Could you also add a test for writing an MBR/GRUB stage 1 sector into the image? Since that is a very common guest action on initial install of an OS into a blank disk, and also should NEVER match one of our probes (assuming we never add support for a file format that resembles an MBR master sector), it would be nice to ensure that our restrictions against writing to sector 0 only fire when actually hitting a colliding probe, and not for all writes. Likewise, maybe add a test for writing a sector of all 0 or all FF. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature