On Tue, Nov 11, 2014 at 03:37:11PM +0100, Andrew Jones wrote: [...] > Below is a v2 I can post if it looks good to you. > > From: Andrew Jones <drjo...@redhat.com> > Date: Fri, 7 Nov 2014 15:45:07 +0100 > Subject: [PATCH v2] vl: sanity check cpu topology > > smp_parse allows partial or complete cpu topology to be given. > In either case there may be inconsistencies in the input which > are currently not sounding any alarms. In some cases the input > is even being silently corrected. Stop silently adjusting input > and abort when the complete cpu topology has been input, but > isn't correct. > > Signed-off-by: Andrew Jones <drjo...@redhat.com>
After applying this patch: $ ./install/bin/qemu-system-x86_64 -smp 12 cpu topology: error: sockets (1) * cores (1) * threads (1) < smp_cpus (12) That is why I wanted to address the most obvious (and less risky) issues first (aborting only if all options were explicitly set), and touch automatic calculation later. -- Eduardo
