Greg Bellows <greg.bell...@linaro.org> writes:
> Adds initialization of the battery ID field so that it is discoverable by name
> (ID) when needed by power commands.
>
> Signed-off-by: Greg Bellows <greg.bell...@linaro.org>
> ---
> hw/misc/goldfish_battery.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/hw/misc/goldfish_battery.c b/hw/misc/goldfish_battery.c
> index a0bc379..11a2561 100644
> --- a/hw/misc/goldfish_battery.c
> +++ b/hw/misc/goldfish_battery.c
> @@ -141,6 +141,11 @@ static void goldfish_battery_realize(DeviceState *dev,
> Error **errp)
> SysBusDevice *sbdev = SYS_BUS_DEVICE(dev);
> struct goldfish_battery_state *s = GOLDFISH_BATTERY(dev);
>
> + /* Initialize the device ID so the battery can be looked up during
> monitor
> + * commands.
> + */
> + dev->id = strdup("goldfish_battery");
> +
We should probably use g_strdup() here.
> memory_region_init_io(&s->iomem, OBJECT(s), &goldfish_battery_iomem_ops,
> s,
> "goldfish_battery", 0x1000);
> sysbus_init_mmio(sbdev, &s->iomem);
--
Alex Bennée
