On (Mon) 17 Nov 2014 [17:15:03], dcb wrote: > Public bug reported: > > hw/virtio/virtio-rng.c:150:31: warning: logical not is only applied to > the left hand side of comparison [-Wlogical-not-parentheses] > > if (!vrng->conf.period_ms > 0) { > error_setg(errp, "'period' parameter expects a positive integer"); > return; > } > > Maybe better code > > if (vrng->conf.period_ms <= 0) { > error_setg(errp, "'period' parameter expects a positive integer"); > return; > }
Thanks! Do you want to submit a patch, since you've identified the fix as well? Amit