On Mon, Nov 17, 2014 at 04:25:50PM +0100, Andreas Färber wrote: > Am 17.11.2014 um 16:19 schrieb Marc Marí: > > El Mon, 17 Nov 2014 15:16:21 +0000 > > Stefan Hajnoczi <stefa...@gmail.com> escribió: > >> On Sat, Nov 01, 2014 at 06:02:26PM +0100, Marc Marí wrote: > >>> Convert use of pointers in functions of virtio to uint64_t in order > >>> to make it platform-independent. > >>> > >>> Add casting from pointers (in PCI functions) to uint64_t and vice > >>> versa through uintptr_t. > >>> > >>> Signed-off-by: Marc Marí <marc.mari.barc...@gmail.com> > >>> --- > >>> tests/libqos/virtio-pci.c | 20 +++++++++++--------- > >>> tests/libqos/virtio.c | 8 ++++---- > >>> tests/libqos/virtio.h | 16 ++++++++-------- > >>> tests/virtio-blk-test.c | 21 ++++++++++++++------- > >>> 4 files changed, 37 insertions(+), 28 deletions(-) > >> > >> This makes sense. To fully abolish pointers the PCI code also needs > >> to be converted. Do plan plan to do that? > >> > >> Stefan > > > > Not planned, but if asked, I may do it. > > Pretty please. :) I was wondering the same thing when reading the patch.
That said, you do not need to convert PCI in this patch series. If you do the PCI conversion in a separate patch series we can keep merging code incrementally. It's more satisfying for you that way and less intimidating for code reviews to review short series. Stefan
pgpK9RujbspDI.pgp
Description: PGP signature