Hi,
It seems the chardev stuff is in spice server since 0.9.
commit 7bbc2ba090788d844573e044041480ff6e3cba7b
Author: Gerd Hoffmann <kra...@redhat.com>
Date: Tue Dec 14 12:56:15 2010 +0100
move chardevs out of experimental
Also, in 0.10, 2 migration functions got moved to spice.h
commit cd402151def11c5748065de28d124747df09447b
Author: Yonit Halperin <yhalp...@redhat.com>
Date: Mon Oct 3 11:21:38 2011 +0200
server/spice.h: semi-seamless migration interface, RHBZ #738266
I think it is thus useless to include spice-experimental.h since 0.10.
(I haven't checked yet)
On Wed, Nov 19, 2014 at 10:55 AM, Gerd Hoffmann <kra...@redhat.com> wrote:
> On Mo, 2014-11-17 at 20:19 +0300, Michael Tokarev wrote:
>> 17.11.2014 18:52, Marc-André Lureau wrote:
>> > Nothing seems to be using functions from spice-experimental.h (better
>> > that way). Let's remove its inclusion.
>>
>> Is it with current spice, or with some older spice too?
>> I mean, why this include has been added to start with -- was it
>> because of some feature which initially was only in -experimental.h
>> but later moved to main spice? If yes, it'd be interesting to see
>> when, in which version of spice, that has been done. Or at least
>> to verify that the minimal version of spice required by qemu (in
>> configure) allows to stop including -experimental.h....
>>
>> So basically, my only question here is -- what version of spice
>> did you check -- especially, did you check the current minimal
>> required version too?
>
> minimum required spice-server is 0.12.0. IIRC the char channel stuff
> used to be in experimental, but I think that predates 0.12.0. Marc?
>
> cheers,
> Gerd
>
>
--
Marc-André Lureau
