On Tue, 2010-03-09 at 18:18 +0200, Michael S. Tsirkin wrote: > On Tue, Mar 09, 2010 at 09:11:33AM -0700, Alex Williamson wrote: > > On Tue, 2010-03-09 at 17:30 +0200, Michael S. Tsirkin wrote: > > > On Tue, Mar 09, 2010 at 08:19:12AM -0700, Alex Williamson wrote: > > > > A filtering flags bitmap is a logical choice here, but I found the > > > > overhead to be non-trivial, which is why we have separate variables for > > > > the other filtering options. > > > > > > You suggest more flags for multicast etc? > > > > I'm suggesting we may get slightly better performance if we use separate > > filter_mac and filter_vlan variable flags instead of a single > > "filtering" flags bitmap. > > Why? It's a single operation anyway, and we use less cache.
Sorry, I must have been thinking of a runtime vs compile time shift. Alex
