On Fri, Nov 21, 2014 at 11:17:02AM +0100, Christian Borntraeger wrote: > Am 19.11.2014 um 11:17 schrieb Ekaterina Tumanova: > > Move the IOCTL calls that detect logical blocksize from raw_probe_alignment > > into separate function (probe_logical_blocksize). > > Introduce function which detect physical blocksize via IOCTL > > (probe_physical_blocksize). > > Both functions will be used in the next patch. > > > > Signed-off-by: Ekaterina Tumanova <tuman...@linux.vnet.ibm.com> > > From what I can tell this should be a no-op for raw_probe_alignment. > > probe_physical_blocksize looks also good. When this patch is applied > stand-alone, > gcc will complain about a defined but unused function, though. > > So we might want to move this function into patch 3 or just add an > __attribute__((unused)) > here (and remove that in patch 3). Or just leave it as is.
Please move probe_physical_blocksize() to Patch 3 because some QEMU builds default to -Werror where this patch causes a build failure. (In order for git-bisect(1) to work patches must not break the build.) Stefan
pgpo4bEkT9sy2.pgp
Description: PGP signature
