On 2014-11-25 at 14:20, Markus Armbruster wrote:
Max Reitz <mre...@redhat.com> writes:
On 2014-11-25 at 13:21, Markus Armbruster wrote:
Max Reitz <mre...@redhat.com> writes:
Test 039 used to fail
I'm confused: "used to" suggests it doesn't anymore, but you sending a
patches strongly suggests something's broken.
Well, it used to fail before this series. :-P
You're right, this sounds bad. Currently, 039 does fail, at least on
any system with a /proc/sys/kernel/core_pattern passing the dump to
another program. After this series, it does no longer.
because qemu-io -c abort may generate core dumps
even with ulimit -c 0 (and the output then contains "(core dumped)").
How?
See the patches[1][2] by Mao Chuan Li. If
/proc/sys/kernel/core_pattern passes the dump to another program,
ulimit -c 0 does not matter.
[1] http://lists.nongnu.org/archive/html/qemu-devel/2014-11/msg02092.html
[2] http://lists.nongnu.org/archive/html/qemu-devel/2014-11/msg02093.html
The problem with those patches is that they require access to
/proc/sys/kernel/core_pattern. I don't like having to run the iotests
as root.
To me, this sounds like a case of "doctor, it hurts when I do this".
What do you mean? That I don't want the iotests to run as root? Or that
I don't want to go the alternative of filtering out the "(core dumped)"
message?
039 doesn't need a core dump. abort() generates a core dump. Why are we
using abort()? Makes no sense. So don't use it.
I can see that people may want to use qemu-io -c abort to generate a
core dump, though, which is why I'm not simply replacing the abort()
call by raise(SIGKILL).
Max
