On 2014-11-26 at 16:19, Eric Blake wrote:
On 11/26/2014 02:13 AM, Max Reitz wrote:
On 2014-11-26 at 08:23, Markus Armbruster wrote:
Max Reitz <mre...@redhat.com> writes:
Albeit absolutely impossible right now, bdrv_find_format("qcow2") may
fail. bdrv_append_temp_snapshot() should heed that case.
Impossible because we always compile in bdrv_qcow2.
+++ b/block.c
@@ -1320,6 +1320,12 @@ int bdrv_append_temp_snapshot(BlockDriverState
*bs, int flags, Error **errp)
}
bdrv_qcow2 = bdrv_find_format("qcow2");
+ if (!bdrv_qcow2) {
Would it be shorter to 'assert(bdrv_qcow2);' to still silence Coverity?
Sounds like a good compromise. Will do.
Max
