Am 27.11.2014 um 17:49 schrieb Paolo Bonzini: > > On 27/11/2014 11:15, Peter Lieven wrote: >> vring_map causes a huge overhead by calling memory_region_find everytime. >> the vring_map is executed already on vring_setup and there is also the memory >> region referenced. >> >> Signed-off-by: Peter Lieven <p...@kamp.de> > vring_map/unmap is going to disappear and be replaced by > address_space_map/unmap, so for now I'd rather keep it...
the issue with vring_map/unmap is that it is called at every vring_pop/push to calculate the descriptor ptr. its ok to call it in vring_setup/destroy and there it doesn't hurt. looking at address_space_map/unmap this would be expensive as well if it is called in every vring_pop/push. Peter
