On Wed, Dec 03, 2014 at 02:37:23PM +0100, Max Reitz wrote: > qcow2_update_cluster_refcount() does not have any quick access to the > new refcount value, it has to call qcow2_get_refcount(). Some callers do > not need that new value at all, others call qcow2_get_refcount() > themselves anyway (albeit in a different code path, which can however be > easily changed), therefore there is no advantage in making > qcow2_update_cluster_refcount() return the new value. Drop it. > > Signed-off-by: Max Reitz <mre...@redhat.com> > --- > block/qcow2-refcount.c | 25 +++++++++++++++---------- > 1 file changed, 15 insertions(+), 10 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com>
pgpqAbF4OhoIM.pgp
Description: PGP signature
