On 11/12/2014 14:02, Kevin Wolf wrote:
>> > > > - } else {
>> > > > - i = ret;
>> > > > + abort();
>> > > > }
> > >
> > > abort() doesn't feel right here.
> >
> > man doesn't suggest any error that can actually happen.
>
> Yes. I guess I just like to be on the safe side. I would be fine with
> dropping requests on the floor and thereby breaking the block device in
> this unlikely case if proper error handling is too hard, but killing the
> qemu process generally makes me feel uncomfortable.
Hmm, since it shouldn't happen I prefer for it to fail right away and
make it easier to spot what happened in the core dump.
Paolo
