On 12/16/14 13:42, Richard W.M. Jones wrote: > On Tue, Dec 16, 2014 at 12:25:41PM +0000, Peter Maydell wrote: >> On 16 December 2014 at 12:20, Alexander Graf <ag...@suse.de> wrote: >>> The patch as is assumes that AArch64 images are always gzipped. I don't >>> think this assumption is correct - if you do "make Image" on a kernel >>> source tree, you will get an uncompressed Image file. >>> >>> I think we'd be better off trying to load it as gzip and if it's not >>> gzipped, fall back to linear load. >> >> Ah, I see what you mean. Yes, we need to continue to support >> loading non-compressed Images as well as compressed ones, >> so this patch needs to do the try-and-fall-back, in the >> same way the current loader code does. > > Hang on, I tested the non-compressed case when I originally submitted > the patch. > > And indeed it does work (still):
The bug is not in your patch; it's in mine, because it doesn't follow the fallback behavior that your patch correctly implements. I guess I'll get to use the get_image_size() / load_image_size() functions after all... Thanks Laszlo
