On 8 January 2015 at 14:30, Don Slutz <dsl...@verizon.com> wrote: > This will output the QEMU_PKGVERSION which is set by configure's > --with-pkgversion=
> + /* Report pkgversion */ > + if (!strcmp(cmdname, "--pkgversion")) { > + argc--; argv++; /* Drop special arg. */ > + printf("qemu-img version " QEMU_VERSION > + " pkgversion " QEMU_PKGVERSION "\n"); > + if (argc < 2) { > + return 0; > + } > + cmdname = argv[1]; /* Update */ > + } Wouldn't it be better to just report the QEMU_PKGVERSION as part of the version info we already report in --version? This would be consistent with both linux-user and the softmmu emulators, which do: printf("QEMU emulator version " QEMU_VERSION QEMU_PKGVERSION ", Copyright (c) 2003-2008 Fabrice Bellard\n"); -- PMM