Re: [Qemu-devel] [RFC PATCH v7 12/21] replay: recording and replaying clock ticks

[Paolo Bonzini]

On 12/01/2015 13:43, Pavel Dovgaluk wrote:
>>> > > +#define REPLAY_CLOCK(clock, value)                                     
>>> > >  \
>>> > > +    (replay_mode == REPLAY_MODE_PLAY ? replay_read_clock((clock))      
>>> > >  \
>>> > > +        : replay_mode == REPLAY_MODE_RECORD                            
>>> > >  \
>>> > > +            ? replay_save_clock((clock), (value))                      
>>> > >  \
>>> > > +        : (value))
>>> > > +
>> > 
>> > Inline functions please, not macros.
> Macro is required here, because I do not want the "value" to be computed in
> replay mode at all.

Indeed you're right.

Paolo