On 13/01/2015 19:40, Peter Maydell wrote: > On 13 January 2015 at 17:52, Paolo Bonzini <pbonz...@redhat.com> wrote: >> The block layer is now using __thread unconditionally. > > Where? I did a quick grep for __thread and (other than stuff in > the *-user code and some Win32 specific files) there's no use of > __thread outside the DEFINE_TLS wrappers.
It's in the pull request. >> Remove the >> "fake" TLS wrappers (that actually aren't TLS on !Linux) in >> include/qemu/tls.h, and add a testcase. > > What platforms have you tested on? We definitely shouldn't > widen our use of __thread without testing it on all the > platforms we support... Native TLS is supported by all platforms except Windows and, I think, OpenBSD, which will have to use GCC's emulated TLS. For Windows we already do. OpenBSD ports will have to use a new-enough GCC (basically depend on the GPLv3 GCC port). Paolo
