On Tue, 20 Jan 2015, Peter Maydell wrote: > In this particular case, this part of the file is fine and the > problem is simply that this patch as it stands introduces a single > line (the one above) that's not indented correctly. The only fix > required is to delete one space in the line added by the patch > (thus avoiding introducing any new misindented lines).
Right! That's what I've been following too -- not to introduce misindentation despite any surrounding lines suffering from this problem. > In the general case, we tend to not do whole-file reindentation, > because it breaks 'git blame' and similar tools. It's not an > outright ban, though -- I guess it comes down to a maintainer > judgement call whether they think the benefit outweighs the cost > for a particular bit of code. Fair enough. In some cases misindentation causes confusion, but here it does seem to be the case. Maciej
