[Qemu-devel] target-tricore: MISSING_BREAK in gen_compute_branch(), false positive?

[Markus Armbruster]

Coverity reports

    Error: MISSING_BREAK:
    target-tricore/translate.c:1648: unterminated_case: This case (value 
"OPC1_32_B_JLA") is not terminated by a 'break' statement.
    target-tricore/translate.c:1650: fallthrough: The above case falls through 
to this one.

Here's the code:

    case OPC1_32_B_JLA:
        tcg_gen_movi_tl(cpu_gpr_a[11], ctx->next_pc);
    case OPC1_32_B_JA:
        gen_goto_tb(ctx, 0, EA_B_ABSOLUT(offset));
        break;

If the fall through is intentional, please add a comment, like this:

    case OPC1_32_B_JLA:
        tcg_gen_movi_tl(cpu_gpr_a[11], ctx->next_pc);
        /* fall through */
    case OPC1_32_B_JA:
        gen_goto_tb(ctx, 0, EA_B_ABSOLUT(offset));
        break;