On 26 January 2015 at 14:59, Chen Gang S <gang.c...@sunrus.com.cn> wrote: > On 1/26/15 06:10, Peter Maydell wrote: >> I would just like the commit message to be clear about the >> scope of the work the patch covers. If the patch is just "Fix >> mismatched lock/unlock calls in IPC struct conversion functions" >> then that's fine, but the commit message should say that. At the >> moment the commit message is very vague. >> > > OK, thanks. > > I am not quite familiar with this file, so I describe the modification > by function name, e.g. lock_user_struct() and unlick_user_struct() in > the patch subject.
In a big file I think it's often more useful to describe the functions which are being changed. My suggested subject would be: "Fix mismatched lock/unlock calls in IPC struct conversion functions" Riku can decide if he wants a v2 or will just fix it up as he applies it to his linux-user tree. -- PMM
