I believe thats what we concluded too
Cheers
Mark.
> On 30 Jan 2015, at 14:06, Paolo Bonzini <pbonz...@redhat.com> wrote:
>
>
>
> On 30/01/2015 13:56, Pavel Dovgaluk wrote:
>>> Could this be static? (I haven't checked).
>>
>> No, because it is used from several replay files.
>
> I wonder if that's a layering violation.
>
>>> Perhaps qemu_system_vmstop_request_prepare +
>>> qemu_system_vmstop_request(RUN_STATE_PAUSED) instead of exit? Those two
>>> functions are thread-safe.
>>
>> There is no need to stop when replay file is over (because we cannot replay
>> more).
>> Should we send shutdown request instead?
>
> I thought about it. I think no, because shutdown is irreversible (see
> runstate_needs_reset). Just pausing seemed to be the right compromise,
> and then the next "cont" can run the VM out of replay mode.
>
> Paolo
+44 (0)20 7100 3485 x 210
+33 (0)5 33 52 01 77x 210
+33 (0)603762104
mark.burton
