On 27 January 2015 at 23:58, Greg Bellows <greg.bell...@linaro.org> wrote: > Added machvirt parsing of feature keywords added to the -cpu command line > option. Parsing occurs during machine initialization.
> - vbi = find_machine_info(cpu_model); > + /* Separate the actual CPU model name from any appended features */ > + cpustr = g_strsplit(cpu_model, ",", 2); > + > + vbi = find_machine_info(cpustr[0]); It seems a shame we have to do this kind of manual string fiddling in every board model, but that is definitely not a problem to address in this patchset. > @@ -604,6 +610,13 @@ static void machvirt_init(MachineState *machine) > } > cpuobj = object_new(object_class_get_name(oc)); > > + /* Handle any CPU options specfied by the user */ "specified" > + cc->parse_features(CPU(cpuobj), cpustr[1], &err); > + if (err) { > + error_report("%s", error_get_pretty(err)); > + exit(1); > + } Otherwise Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> thanks -- PMM