Paolo Bonzini <pbonz...@redhat.com> wrote: > On 05/02/2015 12:33, Zhang Haoyu wrote: >> fix mc146818rtc wrong subsection name to avoid vmstate_subsection_load() fail >> during incoming migration or loadvm. >> >> Signed-off-by: Zhang Haoyu <zhan...@sangfor.com.cn> >> --- >> hw/timer/mc146818rtc.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/hw/timer/mc146818rtc.c b/hw/timer/mc146818rtc.c >> index 5a107fa..0600c9a 100644 >> --- a/hw/timer/mc146818rtc.c >> +++ b/hw/timer/mc146818rtc.c >> @@ -734,7 +734,7 @@ static int rtc_post_load(void *opaque, int version_id) >> } >> >> static const VMStateDescription vmstate_rtc_irq_reinject_on_ack_count = { >> - .name = "irq_reinject_on_ack_count", >> + .name = "mc146818rtc/irq_reinject_on_ack_count", >> .version_id = 1, >> .minimum_version_id = 1, >> .fields = (VMStateField[]) { >> > > Adding Amit. > > Reviewed-by: Paolo Bonzini <pbonz...@redhat.com> > > It would be nice if registering a subsection automatically caught > wrongly-named ones...
You are right here. THere is another check that I would like, that we only have subsections at the top livel. Thanks, JUan. > Paolo