On 02/05/2015 11:58 AM, Max Reitz wrote: > As part of the required changes, this fixes a bug where specifying an > invalid driver would result in the block layer probing the image format; > now it will result in an error, unless "<unset>" is specified as the > driver name. Fixing this would require further work on the xen_disk code > which does not seem worth it (at this point and for this patch).
With enough hand-waving in the commit message, you can justify practically any partial fix :) Strictly better than pre-patch, and I agree that worrying about the remaining warts is out of scope for this series. > > Signed-off-by: Max Reitz <mre...@redhat.com> > --- > hw/block/xen_disk.c | 27 +++++++++++---------------- > 1 file changed, 11 insertions(+), 16 deletions(-) > Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
