On Mon, Jan 19, 2015 at 03:34:56PM +0100, Ekaterina Tumanova wrote: > Updates v5 -> v6: > > Minor Updates according the last review from Stefan Hajnoczi: > 1. Do not change the flow of code, factored out of raw_probe_alignment. > 2. added #ifdef __linux__ in 2 places of raw-posix.c, mentioned by reviewer. > 3. adjusted the comment hdev_probe_geometry according suggestment. > 4. use bdrv_nb_sectors(bs) instead of bs->total_sectors. > 5. do not discard error blk_probe_blocksizes(). now has rc. > 6. put the 512-byte default blocksize value in blkconf_blocksizes. > 7. drop the default parameter from the DEFINE_PROP_BLOCKSIZE() macro.
Unfortunately this series breaks "make check" so it cannot be merged: GTESTER check-qtest-x86_64 qemu-system-x86_64: logical_block_size must be 512 for IDE qemu-system-x86_64: Device initialization failed. qemu-system-x86_64: Initialization of device ide-cd failed Broken pipe GTester: last random seed: R02S942fac7e56eff09e8ab7a7f7fecf847e
pgpj8UJbTTEol.pgp
Description: PGP signature
