On 2/13/15 06:31, Chris Metcalf wrote: > On 2/11/2015 10:32 PM, Chen Gang S wrote: >> And excuse me, my English is not quite well, I don't quite understand: >> >> "fixing anything that breaks as a result". >> >> Could you provide more details? Thanks. > > So if you undefine TARGET_NR_open, etc, hopefully qemu will build. If it does > not build, you should probably find out why, and fix it. Perhaps you can use > NR_openat as a replacement for NR_open, etc. >
Originally, I have tried to remove TARGET_NR_open and others, they can not pass building, and I also noticed about NR_openat. But at last, I still remain TARGET_NR_open and others (with related comments): - Another platforms (e.g. microblaze, arm64) defined them, too. - It is only for linux-user, can bypass Linux tile kernel. So it is still correct. - It really wastes memory and storage a little, but for me, the related maintainers (not me) need to consider about whether let the code more complex or save memory a little. >> Welcome the related diffs, I guess, it must be helpful. :-) > > I uploaded it to: > > http://173.201.26.195/scm/qemu-kvm-0.13.0.get > > Notice that this is against a much older version of qemu, though. > OK, thanks. After read through, it is useful to me. :-) Thanks. -- Chen Gang Open, share, and attitude like air, water, and life which God blessed
