On 24.03.2010, at 22:56, Dmitry Ilyevsky wrote: > > Hello All, > > Please review patch for TBL SPR read access for generic PPC. > > Description: > > POWER specification docs define TBL/TBU SPRs as readable in user and > privileged modes. Therefore SPRs permissions were changed in gen_tbl function > in target-ppc/translate_init.c file. > > Testing: > > Tested with vxworks-6.2 bsp and OS on custom qemu board that includes ppc405 > emulated core
A couple of comments to this patch. 1) Please don't top-post. 2) Always put a Signed-off-by: in the patch 3) Put the patch description into the patch, so git knows what to do with it 4) Don't use html features in mail :-) The patch looks good otherwise. Alex