On Mon, Feb 23, 2015 at 10:55:53AM +0000, Dr. David Alan Gilbert wrote:
> * Stefan Hajnoczi (stefa...@gmail.com) wrote:
> > On Thu, Feb 19, 2015 at 11:40:26AM +0000, Dr. David Alan Gilbert (git)
> > wrote:
> > > From: "Dr. David Alan Gilbert" <dgilb...@redhat.com>
> > >
> > > This patchset provides a way of setting options on an incoming
> > > migration before the fd/process/socket has been created.
> > >
> > > start qemu with -incoming defer
> > > <use the monitor to set whatever you need>
> > > migrate_incoming theuri
> >
> > Does this patch series break BDRV_O_INCOMING?
> >
> > blockdev.c:blockdev_init():
> > if (runstate_check(RUN_STATE_INMIGRATE)) {
> > bdrv_flags |= BDRV_O_INCOMING;
> > }
> >
> > The block layer needs to know about incoming migrations to avoid
> > accessing or caching disk images while the source host still has them
> > open.
>
> No, it doesn't break it; it goes into RUN_STATE_INMIGRATE at startup
> in the same way that all existing -incoming's do; the state transitions
> should be identical.
Great, thanks for explaining.
I have verified that vl.c:main() sets RUN_STATE_INMIGRATE in all cases:
case QEMU_OPTION_incoming:
incoming = optarg;
runstate_set(RUN_STATE_INMIGRATE);
break;
Stefan
pgpfWXF9eZhF0.pgp
Description: PGP signature
